EDN Admin
Well-known member
I have written a class to make a connection to sql database thinking that I dont need to write the connection query all the time to execute a query. Below is my connection class.
First of all I want to know whether I have taken a right decision by creating a new class to make the connections. Secondly, I am getting an error on the below class I wrote. The error is " Concept.DBConnection.Getconnection(): not all code
paths return a value" <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small
<a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small class<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small DBConnection<a> <a> <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small public<span style="font-size:small <span style="font-size:small
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small static<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small Getconnection()<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small try<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small StreamReader<span style="font-size:small <span style="font-size:small servername =
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small new<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small StreamReader<span style="font-size:small <span style="font-size:small (<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "C:\Settings.txt"<span style="font-size:small <span style="font-size:small );<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small string<span style="font-size:small <span style="font-size:small datasource = servername.ReadToEnd();<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small cnn =
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small new<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small (<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "user
id=sa;password=123;server="<span style="font-size:small <span style="font-size:small + datasource +
<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small ";"<span style="font-size:small <span style="font-size:small +
<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "Trusted_Connection=yes;database=concept;connection timeout=30"<span style="font-size:small <span style="font-size:small );<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="font-size:small <span style="font-size:small
cnn.Open();
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small return<span style="font-size:small <span style="font-size:small cnn;<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
}
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small catch<span style="font-size:small <span style="font-size:small (<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small Exception<span style="font-size:small <span style="font-size:small
ex)<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small MessageBox<span style="font-size:small <span style="font-size:small .Show(<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "Cannot
open connection ! "<span style="font-size:small <span style="font-size:small + ex.ToString());<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
}
}
}
<a>
public
View the full article
First of all I want to know whether I have taken a right decision by creating a new class to make the connections. Secondly, I am getting an error on the below class I wrote. The error is " Concept.DBConnection.Getconnection(): not all code
paths return a value" <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small
<a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <a> <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small class<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small DBConnection<a> <a> <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small public<span style="font-size:small <span style="font-size:small
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small static<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small Getconnection()<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small try<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small StreamReader<span style="font-size:small <span style="font-size:small servername =
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small new<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small StreamReader<span style="font-size:small <span style="font-size:small (<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "C:\Settings.txt"<span style="font-size:small <span style="font-size:small );<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small string<span style="font-size:small <span style="font-size:small datasource = servername.ReadToEnd();<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small cnn =
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small new<span style="font-size:small <span style="font-size:small
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small SqlConnection<span style="font-size:small <span style="font-size:small (<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "user
id=sa;password=123;server="<span style="font-size:small <span style="font-size:small + datasource +
<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small ";"<span style="font-size:small <span style="font-size:small +
<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "Trusted_Connection=yes;database=concept;connection timeout=30"<span style="font-size:small <span style="font-size:small );<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
<span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="color:#008000; font-size:small <span style="font-size:small <span style="font-size:small
cnn.Open();
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small return<span style="font-size:small <span style="font-size:small cnn;<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
}
<span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small <span style="color:#0000ff; font-size:small catch<span style="font-size:small <span style="font-size:small (<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small Exception<span style="font-size:small <span style="font-size:small
ex)<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
{
<span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small <span style="color:#2b91af; font-size:small MessageBox<span style="font-size:small <span style="font-size:small .Show(<span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small <span style="color:#a31515; font-size:small "Cannot
open connection ! "<span style="font-size:small <span style="font-size:small + ex.ToString());<span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small <span style="font-size:small
}
}
}
<a>
public
View the full article